From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@scylladb.com>
Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com
 [209.85.208.195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 94D424429A8
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 17 Oct 2019 10:38:51 +0300 (MSK)
Received: by mail-lj1-f195.google.com with SMTP id q64so1393792ljb.12
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 17 Oct 2019 00:38:51 -0700 (PDT)
Date: Thu, 17 Oct 2019 10:38:49 +0300
From: Konstantin Osipov <kostja@scylladb.com>
Message-ID: <20191017073849.GD17235@atlas>
References: <cover.1571068485.git.kshcherbatov@tarantool.org>
 <e7abbc656973f353a14936bacc4b9ce593c7beb5.1571068485.git.kshcherbatov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e7abbc656973f353a14936bacc4b9ce593c7beb5.1571068485.git.kshcherbatov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 8/9] sql: inherit sql_trigger
	from a new trigger class
List-Id: Tarantool development <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org

* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/10/14 19:07]:
>  struct sql_trigger {
> -	/** The name of the trigger. */
> -	char *zName;
> -	/** The ID of space the trigger refers to. */
> -	uint32_t space_id;
> +	struct trigger base;

I agree with this inheritance path, but it's incomplete

sql_trigger inherits from box_trigger which inherits from
core/trigger.


-- 
Konstantin Osipov, Moscow, Russia