From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7C2E34429A8 for ; Thu, 17 Oct 2019 10:36:44 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id y3so1420249ljj.6 for ; Thu, 17 Oct 2019 00:36:44 -0700 (PDT) Date: Thu, 17 Oct 2019 10:36:42 +0300 From: Konstantin Osipov Message-ID: <20191017073642.GC17235@atlas> References: <60d9fb2635567c5be665bf01a8beae1abe9a1905.1571068485.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60d9fb2635567c5be665bf01a8beae1abe9a1905.1571068485.git.kshcherbatov@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1 5/9] sql: use rlist to organize triggers in a list List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org * Kirill Shcherbatov [19/10/14 19:06]: > Using a rlist structure member to organize structures in a list > is typical practice in the Tarantool core; and reduces costs for > supporting and extending of an existent code. > > With this refactoring using an universal trigger structure in > further patches would be simpler. This is a fine change, but sql_trigger could simply inherit from struct trigger, and get the swap / add/remove api from it. -- Konstantin Osipov, Moscow, Russia