From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A41694429A8 for ; Thu, 17 Oct 2019 10:33:50 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id f23so1026216lfk.7 for ; Thu, 17 Oct 2019 00:33:50 -0700 (PDT) Date: Thu, 17 Oct 2019 10:33:47 +0300 From: Konstantin Osipov Message-ID: <20191017073347.GA17235@atlas> References: <13b180b87580875ff26612193fe7992ac60a45c4.1571068485.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13b180b87580875ff26612193fe7992ac60a45c4.1571068485.git.kshcherbatov@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1 2/9] box: rename struct trigger to lua_trigger List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org * Kirill Shcherbatov [19/10/14 19:06]: > Renamed struct trigger to struct lua_trigger because the 'trigger' > name is too general. Currently Tarantool has non-persistent > AppServer Lua triggers represented with 'trigger' structure so as > SQL-specific persistent trigger object named 'sql_trigger'. > > In scope of this patchset we going to significantly rework > triggers subsystem and introduce a new base trigger class named > 'trigger', so this name is be better to be released. this is actually quite unfortunate, the trigger name is general because it is any kind of trigger, it is not only used in Lua. Just look at the scope of your patch, it's tree-wide. I think the old name was good. Besides, renaming the structure without renaming all of the api to match is faux pas. > -#include "trigger.h" > +#include "lib/core/trigger.h" -- Konstantin Osipov, Moscow, Russia