From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0725741D0BD
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 16 Oct 2019 16:31:06 +0300 (MSK)
Date: Wed, 16 Oct 2019 16:31:06 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191016133106.GD12432@tarantool.org>
References: <cover.1571068485.git.kshcherbatov@tarantool.org>
 <20191015213405.GB898@tarantool.org> <20191016055725.GB16587@atlas>
 <20191016110739.GB11847@tarantool.org>
 <20191016111142.GA16144@atlas>
 <20191016121811.GA12432@tarantool.org>
 <50e10b12-31a5-cfc0-d4ac-76d66512db43@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <50e10b12-31a5-cfc0-d4ac-76d66512db43@tarantool.org>
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v1 0/9]
 schema: rework _trigger space
List-Id: Tarantool development <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org

On 16 Oct 15:53, Kirill Shcherbatov wrote:
> > - name (both have)
> > - func_id (only Lua)
> > - space_id (both have)
> > - type (means one of replace/connection/auth etc; only Lua)
> > - event (only SQL)
> > - action_time (SQL and Lua have sets of timings which don't intersect)
> > - action (only SQL)
> 
> I need to mention that I didn't followed this outdated proposal in the
> refactoring that we are discussing.
> 
> <name> STRING  (both have)
> <space_id> UINT32 (both have)
> <opts> MAP (non of them for now, legacy, but potentially usefull)
> <language> STR (both have)
> <type> STR (both have; currently 'replace' type only - replace trigger;
>                       perhaps we would like to support some different trigger types)

Strictly speaking, this relates only to NoSQL triggers.

> <event_manipulation> STR  {"DELETE", "UPDATE", "INSERT" --
>                                                SQL only? - but it is possible to support it in Lua also}

How is this supposed to be supported in Lua? For NoSQL triggers only "replace"
event is valid, which obviously is non of delete, update or insert.

> <action_timing> STR {"BEFORE", "AFTER" - both have}

AFTER is not the same as on_replace; SQL also has INSTEAD.

> <code> STR (both have)

You format missing func_id which is required for NoSQL triggers and action
(FOR EACH STMT/ROW) which is valid for SQL only.