From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7A6E3438E31 for ; Wed, 16 Oct 2019 03:12:53 +0300 (MSK) Date: Wed, 16 Oct 2019 03:12:41 +0300 From: Alexander Turenko Message-ID: <20191016001241.rmyzmx4xhrd2umjy@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 1/1] box: raise an error on nil replicaset and instance uuid List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org LGTM. CCed Kirill. On Sat, Sep 07, 2019 at 03:26:02PM +0200, Vladislav Shpilevoy wrote: > Before the patch the nil UUID was ignored and a new random one > was generated. This was because internally box treats nil UUID > as its absense. > > Now a user will see an explicit message that nil UUID is a > reserved value. > > Closes #4282 > --- > Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4282-box-cfg-rs-uuid > Issue: https://github.com/tarantool/tarantool/issues/4282 > > src/box/box.cc | 25 +++++++++++++++++-------- > test/app-tap/cfg.test.lua | 12 +++++++++++- > 2 files changed, 28 insertions(+), 9 deletions(-)