From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CAD2B25426 for ; Fri, 13 Sep 2019 04:15:55 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZEN7WbfQjriR for ; Fri, 13 Sep 2019 04:15:55 -0400 (EDT) Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 117D82542E for ; Fri, 13 Sep 2019 04:15:54 -0400 (EDT) Date: Fri, 13 Sep 2019 11:15:52 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [server-dev] [PATCH] lua: pwd: split data fetch from deserialization Message-ID: <20190913081552.4gtjkot42l76eakh@tarantool.org> References: <8b8c10ef080d380f5b9e0ec45f5fcbdf73c209d8.1567433319.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: Alexander Turenko , tarantool-patches@freelists.org Hello, On 05 Sep 00:02, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > LGTM. > > On 04/09/2019 00:42, Alexander Turenko wrote: > > This commit does not change a user visible behaviour. It refactors pwd > > module to explicitly divide code that fetches data from passwd / group > > databases from code that performs deserialization of the data to Lua > > tables. > > > > The idea of splitting of those actions appears when it was observed that > > a call of getpw() / getgr() leads to problems on some systems when it is > > invoked during passwd / group database traveral. > > > > Now it is more obvious that we don't call getpw() during passwd > > traversal and getgr() during group traveral. > > > > Follows up #4428 and #4447. I've checked your patch into 1.10, 2.1, 2.2 and master. -- Regards, Kirill Yukhin