From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DC43A24E36 for ; Thu, 12 Sep 2019 19:44:18 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fd4Kpu0vCIZD for ; Thu, 12 Sep 2019 19:44:18 -0400 (EDT) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9831124E1A for ; Thu, 12 Sep 2019 19:44:18 -0400 (EDT) Date: Fri, 13 Sep 2019 02:44:01 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v2 0/4] Serializer bugs Message-ID: <20190912234401.5mwym6khahljjcf7@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org On Mon, Sep 09, 2019 at 09:00:06PM +0200, Vladislav Shpilevoy wrote: > The patchset fixes several problems about JSON and msgpack serializers. > > 1) msgpackffi didn't use msgpack serializer options; > 2) tuple serializer either; > 3) update of a serializer option was not reflected in its Lua representation; > 4) during serialization too nested tables are silently cropped and there was no > way to prevent it. > > Also it was discovered, that msgpackffi does not care *all* options. Not only > about max_depth. I am not sure if it is worth fixing here (or at all) though. I would not do it here. However it worth to file a follow up issue: we should either fix or document this behaviour. It seems that it may be very unexpected that space:update / upsert does not follow, say, encode_invalid_numbers (if a user use this option and see that it works for other box functions). > > Changes in v2: > - Renames; > - Default value a flag for whether we need to raise an error on a too nested msgpack (was crop, now error). > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4434-box-lua-msgpack-cfg > Issue: https://github.com/tarantool/tarantool/issues/4434 Thank you! The pathset looks mostly okay for me. I gave LGTM (with some minor comments) for the first three patches. I would discuss the option name in the fourth patch. WBR, Alexander Turenko.