From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A245E2161E for ; Tue, 10 Sep 2019 10:17:20 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gXJNnNM0IGVj for ; Tue, 10 Sep 2019 10:17:20 -0400 (EDT) Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 59009215D0 for ; Tue, 10 Sep 2019 10:17:20 -0400 (EDT) Date: Tue, 10 Sep 2019 17:17:03 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH 1/1] test: move luajit-tap suite to luajit repo Message-ID: <20190910141701.nfiehd2usmn7t2jr@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Igor Munkin Cc: tarantool-patches@freelists.org Maybe update the commit to update luajit submodule here, when we'll push the patch to the luajit default branch (named 'tarantool')? While we are here, it worth to update the branch in .gitmodules (now it points to 'tarantool-1.7', but should point to 'tarantool'). If one will use git submodule update --remote, then it can confuse. Can be done right in this commit, just mention it in the commit message. Out-of-source build missed small and luajit-tap test suites (it is already so for small). Don't sure whether it should block the commit. See more in the luajit's patch review: https://www.freelists.org/post/tarantool-patches/PATCH-11-test-add-tests-from-tarantool-source-tree,1 WBR, Alexander Turenko. On Thu, Sep 05, 2019 at 05:01:53PM +0300, Igor Munkin wrote: > * All test chunks related to luajit were moved from tarantool source > tree to the luajit repo > * Adjusted CMakeLists via creating a symlink to luajit test directory > to fix out-of-source tests > > Closed #4478 > --- > .gitignore | 1 + > test/CMakeLists.txt | 10 + > test/luajit-tap/fold_bug_LuaJIT_505.test.lua | 20 -- > test/luajit-tap/gh.test.lua | 17 -- > test/luajit-tap/suite.ini | 5 - > .../table_chain_bug_LuaJIT_494.test.lua | 178 ------------------ > test/luajit-tap/unsink_64_kptr.test.lua | 44 ----- > 7 files changed, 11 insertions(+), 264 deletions(-) > delete mode 100755 test/luajit-tap/fold_bug_LuaJIT_505.test.lua > delete mode 100755 test/luajit-tap/gh.test.lua > delete mode 100644 test/luajit-tap/suite.ini > delete mode 100755 test/luajit-tap/table_chain_bug_LuaJIT_494.test.lua > delete mode 100755 test/luajit-tap/unsink_64_kptr.test.lua