From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9F0EC25AA1 for ; Wed, 4 Sep 2019 07:52:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 38VjVysLT_Gh for ; Wed, 4 Sep 2019 07:52:13 -0400 (EDT) Received: from fallback22.mail.ru (fallback22.m.smailru.net [94.100.176.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0D4FC259C3 for ; Wed, 4 Sep 2019 07:52:10 -0400 (EDT) Received: from [10.161.64.45] (port=34096 helo=smtp37.i.mail.ru) by fallback22.m.smailru.net with esmtp (envelope-from ) id 1i5Sui-0004SU-96 for tarantool-patches@freelists.org; Wed, 04 Sep 2019 13:53:24 +0300 Date: Wed, 4 Sep 2019 13:53:11 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v3 5/6] iproto: refactor error encoding with mpstream Message-ID: <20190904105311.GA15916@atlas> References: <2492bd7b04f74228056aa0a06ec2e5c6ae0482ae.1567435674.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2492bd7b04f74228056aa0a06ec2e5c6ae0482ae.1567435674.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, georgy@tarantool.org, alexander.turenko@tarantool.org * Kirill Shcherbatov [19/09/02 17:55]: > +static void > +mpstream_error_handler(void *error_ctx) > +{ > + *(bool *)error_ctx = true; > +} > + > +static void > +mpstream_iproto_encode_error(struct mpstream *stream, const struct error *error) I think the name should be encode_error_in_mpstream(). Basically, the convention is: - if it is an mpstream method, its name is mpstream_verb_subject - if it is error method, the name is error_verb_subject - if it is a standalone function, the name is verb_subject_.._subject. -- Konstantin Osipov, Moscow, Russia