From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F2362263CD
	for <tarantool-patches@freelists.org>; Wed,  4 Sep 2019 08:23:57 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ixcA-WUCkmLD for <tarantool-patches@freelists.org>;
	Wed,  4 Sep 2019 08:23:57 -0400 (EDT)
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 842802637F
	for <tarantool-patches@freelists.org>; Wed,  4 Sep 2019 08:23:57 -0400 (EDT)
Received: by mail-lj1-f194.google.com with SMTP id h3so12566338ljb.5
        for <tarantool-patches@freelists.org>; Wed, 04 Sep 2019 05:23:57 -0700 (PDT)
Date: Wed, 4 Sep 2019 10:12:00 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [tarantool-patches] Re: [PATCH 4/5] box/console: Fix hang in remote console lua mode
Message-ID: <20190904071200.GP2801@uranus.lan>
References: <20190830214808.17422-1-gorcunov@gmail.com>
 <20190830214808.17422-5-gorcunov@gmail.com>
 <20190903190002.GC15611@atlas>
 <20190903191813.GL2801@uranus.lan>
 <20190904064657.GD30636@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190904064657.GD30636@atlas>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Konstantin Osipov <kostja@scylladb.com>
Cc: tml <tarantool-patches@freelists.org>, Alexander Turenko <alexander.turenko@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>

On Wed, Sep 04, 2019 at 09:46:57AM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [19/09/03 22:45]:
> > > why self.eos but global output_eos? 
> > 
> > because this is not global output but the value bound
> > to a particular session, you can have one server and
> > several clients, where each client have own eos
> > setting. Same applies to next your comment. So that
> > why we need to carry it into object instance.
> 
> I mean, why the variable name is different?

Well, to point that it is related to "self" object
and don't collide with global output_eos when grepping
the source code. But I odn't have strong preference here
will rename. Thanks!