From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0465527653
	for <tarantool-patches@freelists.org>; Wed,  4 Sep 2019 07:25:19 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 2RYOJOogD_VR for <tarantool-patches@freelists.org>;
	Wed,  4 Sep 2019 07:25:18 -0400 (EDT)
Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9C63627639
	for <tarantool-patches@freelists.org>; Wed,  4 Sep 2019 07:25:18 -0400 (EDT)
Received: by mail-lf1-f42.google.com with SMTP id u29so15569617lfk.7
        for <tarantool-patches@freelists.org>; Wed, 04 Sep 2019 04:25:18 -0700 (PDT)
Date: Tue, 3 Sep 2019 11:32:14 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [tarantool-patches] Re: [PATCH 2/5] box/console: Add explicit output EOS mapping
Message-ID: <20190903083214.GK2801@uranus.lan>
References: <20190830214808.17422-1-gorcunov@gmail.com>
 <20190830214808.17422-3-gorcunov@gmail.com>
 <20190903082725.GD9438@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190903082725.GD9438@atlas>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>, Alexander Turenko <alexander.turenko@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>

On Tue, Sep 03, 2019 at 11:27:25AM +0300, Konstantin Osipov wrote:
> >  
> > +local LUA_TERM = ';'
> 
> term is a "terminal", not "terminator", usually. Why not call them

We simply already had

YAML_TERM = '\n...\n'

in this file, so I tried to follow naming scheme. I don't mind
rename it.

> EOF or EOS? Why did you call the constant _TERM  and the array
> _eos? Why assign different names to the same thing?

Well, one of the reason is that I tried to minimize changes, but
I agree that putting everything into one place would be better.
Will rework.

> 
> > +    return serpent.line(..., serpent_opts) .. output_eos["lua"]
> Why put them in a table, given you never access them by a variable
> key? 

because we might extend this table with time when say add sql
formatting and etc.