From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2164F277A6 for ; Mon, 2 Sep 2019 07:22:41 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m9tvnISRhRxe for ; Mon, 2 Sep 2019 07:22:41 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CEE0A27779 for ; Mon, 2 Sep 2019 07:22:40 -0400 (EDT) Date: Mon, 2 Sep 2019 14:22:23 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v1] test: avoid of too long running sql-tap tests Message-ID: <20190902112223.rczw7mxx2m6rwl5k@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "Alexander V. Tikhonov" Cc: tarantool-patches@freelists.org LGTM. Pushed to master, 2.2 and 2.1. WBR, Alexander Turenko. On Mon, Sep 02, 2019 at 08:53:30AM +0300, Alexander V. Tikhonov wrote: > The test sql-tap/gh-3083-ephemeral-unref-tuples.test.lua took > too long runtime and failed to finish in timeout limit of 2 > minutes when it runs near the end of the running queue: > > No output during 120 seconds. Will abort after 120 seconds without output. List of workers not reporting the status: > - 012_sql-tap [sql-tap/gh-3083-ephemeral-unref-tuples.test.lua, vinyl] at var/012_sql-tap/gh-3083-ephemeral-unref-tuples.result:0 > Test hung! Result content mismatch: > [File does not exists: sql-tap/gh-3083-ephemeral-unref-tuples.result] > [Main process] No output from workers. It seems that we hang. Send SIGKILL to workers; exiting... > > Due to suggestion from Konstantin Osipov at gh-3845: > https://github.com/tarantool/tarantool/issues/3845#issue-385735959 > > The following tests: > gh-3083-ephemeral-unref-tuples.test.lua > gh-3332-tuple-format-leak.test.lua > where set to run only on memtx configuration. > > Also the test: > gh-3083-ephemeral-unref-tuples.test.lua > was removed from the test-run 'fragile' option flaky list. > > Closed #4128 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4128-disable-vinyl-test-3083 > Issue: https://github.com/tarantool/tarantool/issues/4128 > > test/sql-tap/engine.cfg | 6 ++++++ > test/sql-tap/suite.ini | 3 +-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/test/sql-tap/engine.cfg b/test/sql-tap/engine.cfg > index dc64bbdbc..693a477b7 100644 > --- a/test/sql-tap/engine.cfg > +++ b/test/sql-tap/engine.cfg > @@ -14,6 +14,12 @@ > "sort.test.lua": { > "memtx": {"engine": "memtx"} > }, > + "gh-3083-ephemeral-unref-tuples.test.lua": { > + "memtx": {"engine": "memtx"} > + }, > + "gh-3332-tuple-format-leak.test.lua": { > + "memtx": {"engine": "memtx"} > + }, > "gh-4077-iproto-execute-no-bind.test.lua": {}, > "*": { > "memtx": {"engine": "memtx"}, > diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini > index ec10383ae..8f3c3eab1 100644 > --- a/test/sql-tap/suite.ini > +++ b/test/sql-tap/suite.ini > @@ -29,6 +29,5 @@ long_run = gh-3332-tuple-format-leak.test.lua, gh-3083-ephemeral-unref-tuples.te > config = engine.cfg > show_reproduce_content = False > pretest_clean = True > -fragile = gh-3083-ephemeral-unref-tuples.test.lua ; gh-4128 > - gh-4077-iproto-execute-no-bind.test.lua ; gh-4459 > +fragile = gh-4077-iproto-execute-no-bind.test.lua ; gh-4459 > selectG.test.lua ; gh-4458 > -- > 2.17.1 >