From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Fri, 30 Aug 2019 10:24:05 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH] box/memtx: strip_core -- Warn on linux only
Message-ID: <20190830072405.GD2801@uranus.lan>
References: <20190828181322.16768-1-gorcunov@gmail.com>
 <20190829121905.h6v6hfheq6g3ejhy@tkn_work_nb>
 <20190829185543.GA2801@uranus.lan>
 <20190829221614.2ohizp2ffdz4vcoa@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190829221614.2ohizp2ffdz4vcoa@tkn_work_nb>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>, Vladimir Davydov <vdavydov.dev@gmail.com>, Konstantin Osipov <kostja@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Fri, Aug 30, 2019 at 01:16:15AM +0300, Alexander Turenko wrote:
> > Wait, do you propose to do similar compile-time check for madvise
> > feature inside tarantool code?
> 
> I imagine it as two functions in small: one for check whether madvise is
> compiled-in (i.e. it is expected to be supported on a platform) and
> another (existing now) whether it is actually works. After that we can
> separately check 'is it supported on a platform' and 'is it works' from
> tarantool code to implement the logic described below.
> 
> Anyway, I would not bother with all this stuff until at least one
> another feature will require something like that.

I see, thanks!