From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Date: Thu, 29 Aug 2019 22:28:45 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH] box/memtx: strip_core -- Warn on
 linux only
Message-ID: <20190829192845.accf2ndau2ohba5o@tarantool.org>
References: <20190828181322.16768-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190828181322.16768-1-gorcunov@gmail.com>
To: tarantool-patches@freelists.org
Cc: Alexander Turenko <alexander.turenko@tarantool.org>, Vladimir Davydov <vdavydov.dev@gmail.com>, Cyrill Gorcunov <gorcunov@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

Hello,

On 28 авг 21:13, Cyrill Gorcunov wrote:
> We know that madvise(MADV_DONTDUMP) is present
> on linux based platforms only (macos doesn't
> support it at all, freebsd requires MADV_NOCORE
> or similar which is unsupported by now) thus
> we should not print a warning on other systems
> to not spam users.
> 
> Fixes #4464

I've checked your patch into 2.2 and master.

--
Regards, Kirill Yukhin