From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 492FB27863 for ; Wed, 28 Aug 2019 21:07:33 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 503-7LxCytls for ; Wed, 28 Aug 2019 21:07:33 -0400 (EDT) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0196827862 for ; Wed, 28 Aug 2019 21:07:32 -0400 (EDT) Date: Thu, 29 Aug 2019 04:07:16 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v1] Set fragile option to flaky tests Message-ID: <20190829010715.pq4z3oxxpsytf232@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "Alexander V. Tikhonov" Cc: tarantool-patches@freelists.org, Kirill Yukhin I don't have objections here. CCed Kirill. Does it actually makes CI more stable (for our and Travis-CI infrastructure)? Just curious. WBR, Alexander Turenko. > diff --git a/test/vinyl/suite.ini b/test/vinyl/suite.ini > index 54e6618d6..c8bc270f3 100644 > --- a/test/vinyl/suite.ini > +++ b/test/vinyl/suite.ini > @@ -12,3 +12,6 @@ is_parallel = True > # throttle.test.lua temporary disabled for gh-4168 > disabled = upgrade.test.lua throttle.test.lua > pretest_clean = True > +fragile = errinj.test.lua ; gh-4346 > + select_consistency.test.lua ; gh-4385 > + throttle.test.lua ; gh-4168 > diff --git a/test/wal_off/suite.ini b/test/wal_off/suite.ini > index 637678c26..ed77be157 100644 > --- a/test/wal_off/suite.ini > +++ b/test/wal_off/suite.ini > @@ -7,3 +7,4 @@ use_unix_sockets_iproto = True > is_parallel = True > pretest_clean = True > disabled = iterator_lt_gt.test.lua > +fragile = iterator_lt_gt.test.lua ; gh-3925 The test is disabled at all, should it be in fragile list too? The same question for throttle.test.lua above (maybe other tests too, I didn't verify it precisely). It does not matter for me, I just observed it and point, because it may be unintentional. You can, say, add issue numbers to 'disabled' values: I don't mind.