From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DD2C5276DF
	for <tarantool-patches@freelists.org>; Wed, 28 Aug 2019 11:05:43 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id IdxmMfGzd2Pr for <tarantool-patches@freelists.org>;
	Wed, 28 Aug 2019 11:05:43 -0400 (EDT)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9D881276CF
	for <tarantool-patches@freelists.org>; Wed, 28 Aug 2019 11:05:43 -0400 (EDT)
Date: Wed, 28 Aug 2019 18:05:40 +0300
From: Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v4 3/5] sql: remove name overloading for SQL builtins
Message-ID: <20190828150540.GA37199@tarantool.org>
References: <cover.1566400979.git.kshcherbatov@tarantool.org>
 <154ee8ea11ae260254b71d32e1299f1272438af1.1566400979.git.kshcherbatov@tarantool.org>
 <17C6E71F-24DF-476D-B5FA-430AF34DC84D@tarantool.org>
 <6c04c60a-8ae6-d1bf-0d67-943f39bd3b81@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6c04c60a-8ae6-d1bf-0d67-943f39bd3b81@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org

On Fri, Aug 23, 2019 at 06:02:12PM +0300, Kirill Shcherbatov wrote:
> Now all SQL builtins are unique, i.e. each function has the only
> hash table entry. This technique requires to remove static argc
> checks for some builtins(substr, round, like, trim, count,
> group_concat). Now they raise a runtime error in case of invalid
> usage.

LGTM.

PS Note that I've sent patch which fixes an assertion fault connected
with wrong number of arguments passed to GREATEST/LEAST functions:
https://www.freelists.org/post/tarantool-patches/PATCH-sql-make-GREATESTLEAST-builtins-accept-at-least-two-args

You can cherry-pick it on your branch, in case it doesn't get
to the master earlier.