From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 28 Aug 2019 14:50:35 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH v3] replication: enter orphan mode on manual replication configuration chage Message-ID: <20190828115035.GB32394@atlas> References: <20190828112028.13875-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190828112028.13875-1-sergepetrenko@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Serge Petrenko List-ID: * Serge Petrenko [19/08/28 14:22]: > Currently we only enter orphan mode when instance fails to connect to > replication_connect_quorum remote instances during local recovery. > On bootstrap and manual replication configuration change an error is > thrown. We better enter orphan mode on manual config change, and leave > it only in case we managed to sync with replication_connect_quorum > instances. lgtm, I would call box_do_set_orphan or box_set_orphan_impl() -- Konstantin Osipov, Moscow, Russia