From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 54D21246C6 for ; Wed, 28 Aug 2019 05:33:32 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ja69qNtk6caX for ; Wed, 28 Aug 2019 05:33:32 -0400 (EDT) Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 13F6B245B7 for ; Wed, 28 Aug 2019 05:33:31 -0400 (EDT) Date: Wed, 28 Aug 2019 12:33:29 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/8] port: move struct port_sql to box/port.h Message-ID: <20190828093329.GE19848@atlas> References: <31f265719574074dbabca4ced925ed1008bb49eb.1566907520.git.korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31f265719574074dbabca4ced925ed1008bb49eb.1566907520.git.korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Nikita Pettik Cc: tarantool-patches@freelists.org, v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org * Nikita Pettik [19/08/27 16:34]: > We are going to use port_sql_create() in box/lua/execute.c so to be able > to call it let's make port_sql_create() non-static and move its > declaration to box/port.h alongside with struct port_sql (since > box/port.h already contains struct port_tuple and struct port_lua). > > No functional changes are provided. lgtm -- Konstantin Osipov, Moscow, Russia