From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EC5E3254BA for ; Mon, 26 Aug 2019 19:02:46 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PrxxfD7s-ovP for ; Mon, 26 Aug 2019 19:02:46 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 568F725450 for ; Mon, 26 Aug 2019 19:02:46 -0400 (EDT) Date: Tue, 27 Aug 2019 02:02:29 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] build: fix linking with static openssl library Message-ID: <20190826230228.aaewsbvtftat6uyg@tkn_work_nb> References: <3124ad309d395d9fe9581499198bcd2de9c83b3c.1566525651.git.alexander.turenko@tarantool.org> <1cf410ba-4709-5a37-24e9-b9d660c01f92@tarantool.org> <20190825111538.y6rwdkq463iaex4f@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190825111538.y6rwdkq463iaex4f@tkn_work_nb> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org On Sun, Aug 25, 2019 at 02:15:38PM +0300, Alexander Turenko wrote: > > > Before this patch we add Z library to OPENSSL_LIBRARIES when > > > BUILD_STATIC is enabled. It is not quite correct: we should do that when > > > OPENSSL_USE_STATIC_LIBS is enabled. However we didn't experienced > > > problems with static linking of libcurl (when BUILD_STATIC is enabled), > > > because OPENSSL_LIBRARIES is added to CURL_LIBRARIES. This is a kind of > > > side effect of dependency libcurl on OpenSSL and it is better to add > > > libz explicitly to CURL_LIBRARIES (and OPENSSL_LIBRARIES) when > > > appropriate. > > > > Is it correct, that all the curl-related changes are just sugar not > > related to the bug? Because I spent some time on attempts to understand, > > how is curl related to the problem, but looks like in no way. > > It is a kind of refactoring, yep. I had understood the problem better > and so wrote better code to fix it. I would start the paragraph with a > remark like: > > > The patch contains changes around linking with libcurl: they does not > > change any behaviour. Consider them as refactoring. > > Then I'll describe why it is changed, why it did work before and so: > just like in the current paragraph. > > I'll let you know when will update the branch. > > WBR, Alexander Turenko. I removed the paragraph of the question and added the following one: | The patch changes OPENSSL_LIBRARIES variable to fix the issue with | static linking of OpenSSL libraries. It also changes CURL_LIBRARIES in | the same way, however this does not alter any visible behaviour, because | OPENSSL_LIBRARIES is added to CURL_LIBRARIES. The latter change was made | to unify the way to choose libraries to link with: it is pure | refactoring part. Hope it clarifies why I touched FindCURL.cmake. Rebased the branch on top of the current master. branch: Totktonada/gh-4437-fix-static-openssl-build-full-ci WBR, Alexander Turenko.