From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F20AA27514 for ; Mon, 26 Aug 2019 18:27:52 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EXZ8UdfIHaZE for ; Mon, 26 Aug 2019 18:27:52 -0400 (EDT) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id AFB602617D for ; Mon, 26 Aug 2019 18:27:52 -0400 (EDT) Date: Tue, 27 Aug 2019 01:27:50 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 2/3] box: rename diag_add_error to diag_set_error Message-ID: <20190826222750.GB1189@atlas> References: <4f87bd09c9b37de0ec1e1b57f46923bae16a64cf.1566553968.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f87bd09c9b37de0ec1e1b57f46923bae16a64cf.1566553968.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, georgy@tarantool.org, alexander.turenko@tarantool.org * Kirill Shcherbatov [19/08/23 13:03]: > Renamed function diag_add_error to diag_set_error because it > actually replaces an error object in diagnostic area with a new > one and this name is not representative. Moreover, we are going > to introduce a new diag_add_error that extends error object in > diagnostic area in following patches. lgtm, it's obvious. -- Konstantin Osipov, Moscow, Russia