From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A2B4B2780F for ; Mon, 26 Aug 2019 11:08:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GlBQhOriPDon for ; Mon, 26 Aug 2019 11:08:17 -0400 (EDT) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EF37C27800 for ; Mon, 26 Aug 2019 11:08:16 -0400 (EDT) Date: Mon, 26 Aug 2019 18:08:06 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] lua: pwd: fix passwd and group traversal Message-ID: <20190826150806.GA12864@tarantool.org> References: <5545c38a61fe1867743a75b6bb4767b8e87c629e.1566524401.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5545c38a61fe1867743a75b6bb4767b8e87c629e.1566524401.git.alexander.turenko@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy , Alexander Turenko Hello, On 23 авг 04:57, Alexander Turenko wrote: > CentOS 6 and FreeBSD 12 implementations of getpwuid() rewind > setpwent()-{getpwent()}-endpwent() loop to a start that leads to a hang > during pwd.getpwall() invoke. The same is true for a getgrgid() call > during setgrent()-{getgrent()}-endgrent() loop. > > The commit modifies pwd module to avoid getpwuid() calls during passwd > database traversal and to avoid getgrgid() calls when traversing groups. > > The commit also fixes the important regression on CentOS 6 after > f5d8331e833d6a29dc7a869e681e03fb8e03a5f8 ('lua: workaround > pwd.getpwall() issue on Fedora 29'): tarantool hungs during startup due > to added getpwall() call. This made tarantool unusable on CentOS 6 at > all. > > Aside of that the commit fixes another pwd.getgrall() problem: the > function gaves password entries instead of group entries. > > Fixes #4428. > Fixes #4447. > Part of #4271. I've checked the patch into 1.10, 2.1, 2.2 and master. -- Regards, Kirill Yukhin