From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AD0B927494
	for <tarantool-patches@freelists.org>; Fri, 23 Aug 2019 07:54:52 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ALlRVhWVvQ4t for <tarantool-patches@freelists.org>;
	Fri, 23 Aug 2019 07:54:52 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F0D3927481
	for <tarantool-patches@freelists.org>; Fri, 23 Aug 2019 07:54:51 -0400 (EDT)
Date: Fri, 23 Aug 2019 14:54:33 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1] gitlab-ci: clean up .gitlab-ci.yml
Message-ID: <20190823115433.s6yjqlxcbthnzde4@tkn_work_nb>
References: <72e11c07b32e8d68702754390dd0a7adcbe6101d.1566540453.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <72e11c07b32e8d68702754390dd0a7adcbe6101d.1566540453.git.avtikhon@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org

The approach is okay for me. Found two mistakes. Please, fix them,
verify all jobs again and pass the patch to Kirill.

WBR, Alexander Turenko.

>  release_asan_clang8:
> -  image: ${IMAGE_TEST_LTO}
> -  stage: test
> -  tags:
> -    - docker_test
> +  <<: *docker_test_lto_definition
>    script:
>      - ${GITLAB_MAKE} test_asan_debian_no_deps

No -DENABLE_LTO=ON cmake flag. It seems that there was no before.

>  static_build:
> -  only:
> -    refs:
> -      - master
> -      - /^.*-full-ci$/
> -  stage: test
> -  tags:
> -    - deploy
> +  <<: *deploy_test_definition
>    variables:
>      RUN_TESTS: 'ON'
> -  script:
> -    - ${GITLAB_MAKE} static_build

static build now runs debian packages build.