From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2CBF927415 for ; Thu, 22 Aug 2019 09:06:22 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nkNvQLZ3sQ3I for ; Thu, 22 Aug 2019 09:06:22 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DE0C5254B2 for ; Thu, 22 Aug 2019 09:06:21 -0400 (EDT) Date: Thu, 22 Aug 2019 16:06:19 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] tarantoolctl doesn't fail when box.cfg is delayed in init script Message-ID: <20190822130619.ntgehuxgnl2ymvah@tarantool.org> References: <20190819073936.37388-1-m.melentiev@corp.mail.ru> <20190819075457.GA18442@atlas> <59464C78-29E6-4F91-B8E9-CA01CB63FE65@corp.mail.ru> <20190819150532.gh25tyc73mcfazeg@tkn_work_nb> <20190820231528.bqfpccu334bfxkbs@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190820231528.bqfpccu334bfxkbs@tkn_work_nb> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Alexander Turenko Cc: Maxim Melentiev , tarantool-patches@freelists.org, Maxim Melentiev , Konstantin Osipov Hello, On 21 Aug 02:15, Alexander Turenko wrote: > On Tue, Aug 20, 2019 at 02:24:23PM +0300, Maxim Melentiev wrote: > > > BTW, is this is enough for you in the scope of your task or we need to > > > boost other tarantoolctl discussions very soon? > > This should be enough to complete our task (with some limitations). > > > > However we decided not to proceed with patching tarantoolctl right now > > and provide start/stop features in rock’s binary replacing ctl for cluster apps. > > Thank you for review. Please, ignore this patch request. > > The patch looks good for me as well. Thanks! > > I think that it is valuable even if your team does not needed it right > now. > > CCed Kirill to decide about branches to which it should land. > > Max, I guess a mainainer may ask you to provide a branch in > tarantool/tarantool repository with your commit at top of current > master. > > Kirill, the patch has LGTMs from Kostya O. and me. Checked into 2.2 and master. -- Regards, Kirill Yukhin