From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 22 Aug 2019 13:07:04 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2] box: add support for decimals in update ops Message-ID: <20190822100704.GC25002@atlas> References: <20190821085808.12236-1-sergepetrenko@tarantool.org> <20190821213726.GC24288@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: To: Serge Petrenko Cc: Vladimir Davydov , tarantool-patches@freelists.org List-ID: * Serge Petrenko [19/08/22 11:59]: > > >> Closes #4413 > >> > >> @TarantoolBot document > >> Title: update operations on decimal fields. > >> > >> tuple:update and space:update now support deicmal operands for > >> arithmetic operations ('+' and '-'). The syntax is as usual: > > > > Please document how type arithmetics work, and cover it with > > tests. > > Hi! I added the following text to the docbot request in commit message: > > «When performing an arithmetic operation ('+', '-'), where either the > updated field or the operand is decimal, the result will be decimal. > When both the updated field and the operand are decimal, the result > will, of course, be decimal.» thanks. lgtm then. -- Konstantin Osipov, Moscow, Russia