From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A5EA027006 for ; Wed, 21 Aug 2019 17:25:32 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aZ6zX6iiwtTQ for ; Wed, 21 Aug 2019 17:25:32 -0400 (EDT) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 635A026023 for ; Wed, 21 Aug 2019 17:25:32 -0400 (EDT) Date: Thu, 22 Aug 2019 00:25:14 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH vshard 1/1] travis-ci: deploy packages from tagged revisions Message-ID: <20190821212513.rjh6s3ls32ezcnxw@tkn_work_nb> References: <02992a76f8e5b7b1e4a53580cec33d050dc20b0b.1566333316.git.v.shpilevoy@tarantool.org> <20190820225932.gof43wv3b3ke5w6g@tkn_work_nb> <43985be3-143d-9e1c-cc60-ecfe94f1c3d3@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <43985be3-143d-9e1c-cc60-ecfe94f1c3d3@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org On Wed, Aug 21, 2019 at 10:40:25PM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the review! > > On 21/08/2019 00:59, Alexander Turenko wrote: > > LGTM. > > > > BTW, while you are here it worth to add uploading of packages into > > tarantool/2_3 packagecloud bucket. > > I added a separate commit, see below and on the branch. Is it ok? Looks ok.