From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7F871275B9 for ; Wed, 21 Aug 2019 06:30:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qWCbtML5q5kp for ; Wed, 21 Aug 2019 06:30:11 -0400 (EDT) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2445927591 for ; Wed, 21 Aug 2019 06:30:11 -0400 (EDT) Received: by mail-lf1-f66.google.com with SMTP id 62so1387538lfa.8 for ; Wed, 21 Aug 2019 03:30:10 -0700 (PDT) From: Yaroslav Dynnikov Subject: [tarantool-patches] [PATCH] feedback: unify payload generation logic Date: Wed, 21 Aug 2019 13:30:06 +0300 Message-Id: <20190821103006.29438-1-yaroslav.dynnikov@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Yaroslav Dynnikov This change is related to #4391. The objective was to collect additional information about modules, but it's hard to do without changing API. This patch will allow to monkey-patch report generation and achieve the same results without interfering the daemon behavior. --- Branch: https://github.com/tarantool/tarantool/tree/rosik/gh-4391-feedback-generation Issue: https://github.com/tarantool/tarantool/issues/4391 src/box/lua/feedback_daemon.lua | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 8a27fbd01..ad71a3fe2 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -37,10 +37,9 @@ end local function feedback_loop(self) fiber.name(PREFIX, { truncate = true }) - local header = { feedback_type = "version", feedback_version = 1 } while true do - local feedback = fill_in_feedback(header) + local feedback = self:generate_feedback() local msg = self.control:get(self.interval) -- if msg == "send" then we simply send feedback if msg == "stop" then -- 2.17.1