From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4B54727526
	for <tarantool-patches@freelists.org>; Tue, 20 Aug 2019 12:22:21 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 2-RlrQyQ1hi0 for <tarantool-patches@freelists.org>;
	Tue, 20 Aug 2019 12:22:21 -0400 (EDT)
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 09BE9234CF
	for <tarantool-patches@freelists.org>; Tue, 20 Aug 2019 12:22:20 -0400 (EDT)
Date: Tue, 20 Aug 2019 19:22:18 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on
 macOS
Message-ID: <20190820162218.GA22134@atlas>
References: <20190819082813.38237-1-m.melentiev@corp.mail.ru>
 <20190819201827.GA21602@atlas>
 <cdf449c5-409d-0f8f-b371-cbe873f1c508@corp.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cdf449c5-409d-0f8f-b371-cbe873f1c508@corp.mail.ru>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Maxim Melentiev <m.melentiev@corp.mail.ru>
Cc: tarantool-patches@freelists.org, alexander.turenko@tarantool.org

* Maxim Melentiev <m.melentiev@corp.mail.ru> [19/08/20 18:29]:
> It's quite  complicated now: cmake WITH_SYSTEMD flag is also used to
> generate systemd units, tarantool-generator and other systemd related files.
> 
> I think that support for NOTIFY_SOCKET should not be systemd-related, as
> it's enabled in runtime by envar and is disabled otherwise.

Then add WITH_NOITFY_SOCKET as a separate option. WITH_SYSTEMD
could imply it.

> On 19/08/2019 23:18, Konstantin Osipov wrote:
> > > -#if defined(WITH_SYSTEMD)
> > I don't think you should remove this ifdef at all. Simply enable
> > it on Mac OSX by default in cmake if it works there now.

-- 
Konstantin Osipov, Moscow, Russia