From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 20 Aug 2019 14:52:48 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [PATCH v2 2/7] vinyl: don't exempt dropped indexes from dump and compaction Message-ID: <20190820115248.GB8932@atlas> References: <67030c30de327fbceaf2c204eec11a3745869533.1566233187.git.vdavydov.dev@gmail.com> <20190819204700.GC21602@atlas> <20190820081227.GQ13834@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190820081227.GQ13834@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/08/20 11:15]: > > Why did you add a trigger - to avoid dependency > > loops between vy_lsm and vy_scheduler? But sounds like it's > > simpler to make vy_lsm aware in vy_scheduler and register/unregister > > itself in create/destroy. Why did you choose to add a trigger > > instead? > > To avoid a dependency loop: vy_scheduler.[hc] depends on vy_lsm.[hc], > but not vice versa, which is nice IMO. > > Besides, I think we could reuse the trigger for other purposes, e.g. to > force data file deletion when an index is finally released. OK. The dependency loop is still there, it's just less explicit. But let it be, it's not a big deal. -- Konstantin Osipov, Moscow, Russia