From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AF20C265AC for ; Mon, 19 Aug 2019 16:54:16 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cDp4DHpELrJj for ; Mon, 19 Aug 2019 16:54:16 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 714A9247C2 for ; Mon, 19 Aug 2019 16:54:16 -0400 (EDT) Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1hzofO-0005ri-QX for tarantool-patches@freelists.org; Mon, 19 Aug 2019 23:54:14 +0300 Date: Mon, 19 Aug 2019 23:54:14 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 6/7] space: get rid of apply_initial_join_row method Message-ID: <20190819205414.GG21602@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/08/19 19:57]: > There's no reason to use a special method instead of the generic > space_execute_dml for applying rows received from a master during the > initial join stage. Moreover, using the special method results in not > running space.before_replace trigger, which makes it impossible to, for > example, update space engine on a replica, see the on_schema_init test > of the replication test suite. > > So this patch removes the special method altogether and makes the code > that used it switch to space_execute_dml. > > Closes #4417 LGTM -- Konstantin Osipov, Moscow, Russia