From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 96893265B0 for ; Mon, 19 Aug 2019 16:51:38 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6vrezcUZ2g2p for ; Mon, 19 Aug 2019 16:51:38 -0400 (EDT) Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 56ED2247C2 for ; Mon, 19 Aug 2019 16:51:38 -0400 (EDT) Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1hzocq-0004Dv-Lo for tarantool-patches@freelists.org; Mon, 19 Aug 2019 23:51:36 +0300 Date: Mon, 19 Aug 2019 23:51:36 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 5/7] memtx: enter small delayed free mode from snapshot iterator Message-ID: <20190819205136.GF21602@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/08/19 19:57]: > We must enable SMALL_DELAYED_FREE_MODE to safely use a memtx snapshot > iterator. Currently, we do that in checkpoint related callbacks, but if > we want to reuse snapshot iterators for other purposes, e.g. feeding > a read view to a newly joined replica, we better hide this code behind > snapshot iterator constructors. As discussed, better garbage collection is a separate patch. With that, lgtm. -- Konstantin Osipov, Moscow, Russia