From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0682122C9C
	for <tarantool-patches@freelists.org>; Thu, 15 Aug 2019 22:30:26 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 2ePidHYlLjFh for <tarantool-patches@freelists.org>;
	Thu, 15 Aug 2019 22:30:25 -0400 (EDT)
Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B8DBA22A9E
	for <tarantool-patches@freelists.org>; Thu, 15 Aug 2019 22:30:25 -0400 (EDT)
Date: Fri, 16 Aug 2019 05:30:09 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1] gitlab-ci: add static build
Message-ID: <20190816023008.ean2vrvwablefviu@tkn_work_nb>
References: <dd7e013dd8b2b16a9f2b46d8a44a226b004b9356.1565325077.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <dd7e013dd8b2b16a9f2b46d8a44a226b004b9356.1565325077.git.avtikhon@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@freelists.org

I looked briefly and it seems to be okay. But, please, remove cleanup
changes from the dockerfile: they hide real changes and bloats the
patch.

I'll look deeper when you'll update the patch.

WBR, Alexander Turenko.

> -RUN set -x \
> -    && yum -y install \
> +RUN set -x && \
> +    yum -y install \

I meant this kind of changes.

> -RUN yum -y install ncurses-static readline-static zlib-static pcre-static glibc-static
> +    yum -y install \
> +        ncurses-static \
> +        readline-static \
> +        zlib-static \
> +        pcre-static \
> +        glibc-static && \
> +    yum -y install \
> +        python-devel \
> +        python-pip

This.

> +WORKDIR /
>  
>  RUN set -x && \
> -    cd / && \
>      curl -O -L https://www.openssl.org/source/openssl-1.1.0h.tar.gz && \
>      tar -xvf openssl-1.1.0h.tar.gz && \
>      cd openssl-1.1.0h && \

And this.