From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 193C926819 for ; Wed, 14 Aug 2019 18:12:36 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E0mw1wqAFEzR for ; Wed, 14 Aug 2019 18:12:36 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6C5B626039 for ; Wed, 14 Aug 2019 18:12:35 -0400 (EDT) Date: Thu, 15 Aug 2019 01:12:32 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] recovery: build secondary index in hot standby mode Message-ID: <20190814221232.GB28533@atlas> References: <20190814183144.17907-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814183144.17907-1-i.kosarev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: georgy@tarantool.org, i.kosarev@corp.mail.ru, Ilya Kosarev * Ilya Kosarev [19/08/14 21:36]: > Secondary index was being built after reading xlog > except for the force recovery case, > when it was being built immediately after reading snapshot. > Now it is also being built immediately after reading snapshot > in case of hot standby mode in order to be ready by the time > original instance quits. > > Closes #4135 > --- > Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4135-secondary-index-for-hot-standby > Issue: https://github.com/tarantool/tarantool/issues/4135 > > src/box/memtx_engine.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/box/memtx_engine.c b/src/box/memtx_engine.c > index 7c3dd8465..2c8653bd9 100644 > --- a/src/box/memtx_engine.c > +++ b/src/box/memtx_engine.c > @@ -48,6 +48,7 @@ > #include "replication.h" > #include "schema.h" > #include "gc.h" > +#include "wal.h" This should not be done by including entire WAL API header.. I wonder maybe we should have a policy that discourages including extra headers? -- Konstantin Osipov, Moscow, Russia