From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9C13F21CD9 for ; Mon, 12 Aug 2019 18:31:57 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x51HAs8Rw98x for ; Mon, 12 Aug 2019 18:31:57 -0400 (EDT) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5AEBD21B87 for ; Mon, 12 Aug 2019 18:31:57 -0400 (EDT) Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1hxIr5-00077N-KZ for tarantool-patches@freelists.org; Tue, 13 Aug 2019 01:31:55 +0300 Date: Tue, 13 Aug 2019 01:31:55 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 12/13] test: disable replication/on_schema_init Message-ID: <20190812223155.GE32337@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/08/10 23:22]: > The test uses box.on_schema_init to install space.before_replace trigger > that changes the engine/locality of a space received by a replica. This > works, only because we don't make a snapshot after creating those spaces > on the master so that they are relayed from an xlog. If we added > box.snapshot(), the test would fail, because space.before_replace > trigger isn't run for changes received on initial join (see #4417). > Once we make the initial join stage work off the current read view > rather than the last snapshot (see #1271), the test will fail as well. > Let's disable the test until the issue is resolved. Ugh. -- Konstantin Osipov, Moscow, Russia