From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E37EE2574C for ; Mon, 12 Aug 2019 18:14:52 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DGUbrCisXocY for ; Mon, 12 Aug 2019 18:14:52 -0400 (EDT) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A510725749 for ; Mon, 12 Aug 2019 18:14:52 -0400 (EDT) Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1hxIaY-00019g-TC for tarantool-patches@freelists.org; Tue, 13 Aug 2019 01:14:51 +0300 Date: Tue, 13 Aug 2019 01:14:50 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 02/13] vinyl: embed index in vy_lsm Message-ID: <20190812221450.GW32337@atlas> References: <3ba5ca48f66a85de7141712155ff8dadc422df45.1565430177.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ba5ca48f66a85de7141712155ff8dadc422df45.1565430177.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/08/10 23:22]: > There's no point in having vinyl_engine and vinyl_index wrapper structs > to bind vy_env and vy_lsm to struct engine and index. Instead we can > simply embed engine and index in vy_env and vy_lsm. This will simplify > further development, e.g. this will allow us to move reference counting > from vy_lsm up to struct index so that it can be used in the generic > code. lgtm -- Konstantin Osipov, Moscow, Russia