From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 584D92574C
	for <tarantool-patches@freelists.org>; Mon, 12 Aug 2019 18:14:12 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 7o5SvxVxgLz8 for <tarantool-patches@freelists.org>;
	Mon, 12 Aug 2019 18:14:12 -0400 (EDT)
Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1969A25749
	for <tarantool-patches@freelists.org>; Mon, 12 Aug 2019 18:14:11 -0400 (EDT)
Received: by smtp39.i.mail.ru with esmtpa (envelope-from <kostja@tarantool.org>)
	id 1hxIZu-0003hJ-9w
	for tarantool-patches@freelists.org; Tue, 13 Aug 2019 01:14:10 +0300
Date: Tue, 13 Aug 2019 01:14:10 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 01/13] vinyl: embed engine in vy_env
Message-ID: <20190812221410.GV32337@atlas>
References: <cover.1565430177.git.vdavydov.dev@gmail.com>
 <54993ef2ba91daee63193d492150eb0baab35bef.1565430177.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54993ef2ba91daee63193d492150eb0baab35bef.1565430177.git.vdavydov.dev@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/08/10 23:22]:
> There's no point in having vinyl_engine and vinyl_index wrapper structs
> to bind vy_env and vy_lsm to struct engine and index. Instead we can
> simply embed engine and index in vy_env and vy_lsm. This will simplify
> further development, e.g. this will allow us to move reference counting
> from vy_lsm up to struct index so that it can be used in the generic
> code.

lgtm

 

-- 
Konstantin Osipov, Moscow, Russia