From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B091D22589 for ; Mon, 12 Aug 2019 18:00:19 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sHEjMtIvGI5N for ; Mon, 12 Aug 2019 18:00:19 -0400 (EDT) Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 58A4E21CCF for ; Mon, 12 Aug 2019 18:00:19 -0400 (EDT) Date: Tue, 13 Aug 2019 01:00:17 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 3/8] sql: wrap all trim functions in dispatcher Message-ID: <20190812220017.GQ32337@atlas> References: <74a116ac889583f76d8617d644f6277073f9fbdd.1565275469.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74a116ac889583f76d8617d644f6277073f9fbdd.1565275469.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov * Kirill Shcherbatov [19/08/08 17:53]: > A new dispatcher function trim_func calls corresponding trim_ > function implementation in relation with number of argc - a count > of arguments. > > This is an important stem to get rid of function's name > overloading required for replace FuncDef cache with Tarantool's > function cache. > > Needed for #2200, #4113, #2233 Agree with Nikita's nit, otherwise lgtm. -- Konstantin Osipov, Moscow, Russia