From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 19F6D2572A
	for <tarantool-patches@freelists.org>; Mon, 12 Aug 2019 17:59:07 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id lLgENgqVEfpF for <tarantool-patches@freelists.org>;
	Mon, 12 Aug 2019 17:59:07 -0400 (EDT)
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CD02D25720
	for <tarantool-patches@freelists.org>; Mon, 12 Aug 2019 17:59:06 -0400 (EDT)
Date: Tue, 13 Aug 2019 00:59:04 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 2/8] sql: GREATEST, LEAST instead
 of MIN/MAX overload
Message-ID: <20190812215904.GP32337@atlas>
References: <cover.1565275469.git.kshcherbatov@tarantool.org>
 <7f7013d0209f432eb1ea12d897527ed9885c3599.1565275469.git.kshcherbatov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7f7013d0209f432eb1ea12d897527ed9885c3599.1565275469.git.kshcherbatov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org, Kirill Shcherbatov <kshcherbatov@tarantool.org>

* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/08/08 17:53]:
> The MIN/MAX functions are typically used only as aggregate
> functions in other RDBMS(MSSQL, Postgress, MySQL, Oracle) while
> Tarantool's SQLite legacy code use them also in meaning
> GREATEST/LEAST scalar function. This must be fixed.
> 
> Moreover it is an important stem to get rid of function's name
> overloading required for replace FuncDef cache with Tarantool's
> function cache.

lgtm (agree with nikita's nits, but otherwise please push, push
push).


-- 
Konstantin Osipov, Moscow, Russia