From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 116662572A for ; Mon, 12 Aug 2019 17:55:57 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H9VLpbmgIK2z for ; Mon, 12 Aug 2019 17:55:57 -0400 (EDT) Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C5E5425508 for ; Mon, 12 Aug 2019 17:55:56 -0400 (EDT) Date: Tue, 13 Aug 2019 00:55:54 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/3] txn: merge struct sql_txn into struct txn Message-ID: <20190812215554.GN32337@atlas> References: <7d398281ec92e03c1d6f5f1bf93970debcfcc684.1565190104.git.korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Nikita Pettik * Vladislav Shpilevoy [19/08/10 00:01]: > > + char *name; > > 8. I didn't like that name is stored by pointer - it consumes more > memory, and is slower. So I changed to name[1] with variable length > tail. But is it an advisory fix, you can skip it if you think it > complicates the code too much. See below and on the branch. Vlad, please, stop this optimization craziness, come on, how big of a deal is it to allocate a name once you already parsed the statement to create this savepoint? -- Konstantin Osipov, Moscow, Russia