From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 88DB82661A for ; Wed, 7 Aug 2019 11:26:43 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hpcPPp1OnZjt for ; Wed, 7 Aug 2019 11:26:43 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 47EB425F70 for ; Wed, 7 Aug 2019 11:26:43 -0400 (EDT) Date: Wed, 7 Aug 2019 18:26:41 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 0/3] Merge struct sql_txn into struct txn/savepoint Message-ID: <20190807152641.GB24486@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik * Nikita Pettik [19/08/07 18:19]: > Branch: https://github.com/tarantool/tarantool/tree/np/move-sql-structs-from-txn > > As a one of final steps of merging SQL and NoSQL codebases, it is > required to squash struct sql_txn and struct txn/struct txn_savepoint. > struct sql_txn was needed to operate on named savepoints. Hence, it > contains name of savepoint and a link to next savepoint. This patch-set > adds optional name of savepoint to struct txn_savepoint and orginizes > txn_savepoints into list. Head of list is held in stuct txn. Iterating > over list allows to find savepoint by its name. Finally, after this > procedure is completed, we can remove struct sql_txn and struct Savepoint. Thanks for the patch, overall LGTM (but I did not look carefully). -- Konstantin Osipov, Moscow, Russia