From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7AF6E26625
	for <tarantool-patches@freelists.org>; Wed,  7 Aug 2019 11:26:06 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id temJqujuOKG1 for <tarantool-patches@freelists.org>;
	Wed,  7 Aug 2019 11:26:06 -0400 (EDT)
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3B6F72447F
	for <tarantool-patches@freelists.org>; Wed,  7 Aug 2019 11:26:06 -0400 (EDT)
Date: Wed, 7 Aug 2019 18:26:03 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/3] txn: merge struct sql_txn into
 struct txn
Message-ID: <20190807152603.GA24486@atlas>
References: <cover.1565190104.git.korablev@tarantool.org>
 <7d398281ec92e03c1d6f5f1bf93970debcfcc684.1565190104.git.korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7d398281ec92e03c1d6f5f1bf93970debcfcc684.1565190104.git.korablev@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>

* Nikita Pettik <korablev@tarantool.org> [19/08/07 18:19]:
> +box_txn_savepoint_t *
> +box_txn_savepoint()
> +{
> +	struct txn *txn = in_txn();
> +	if (txn == NULL) {
> +		diag_set(ClientError, ER_NO_TRANSACTION);
> +		return NULL;
> +	}
> +	return txn_savepoint_new(txn, NULL);
> +}

Please don't use box_ API in SQL. We do not use box_ API
exclusively any more, so there is no point in extra wrappers.


-- 
Konstantin Osipov, Moscow, Russia