From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 180F825877 for ; Wed, 31 Jul 2019 04:23:42 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id njx_SF36OSQI for ; Wed, 31 Jul 2019 04:23:42 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4831225876 for ; Wed, 31 Jul 2019 04:23:41 -0400 (EDT) Date: Wed, 31 Jul 2019 11:23:24 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH 1/1] test: fix flaky swim/errinj.test.lua Message-ID: <20190731082323.gn2dlibe7lntwuln@tkn_work_nb> References: <370fd137fece7c2ec40108893a63dec35aaf9b85.1564515238.git.v.shpilevoy@tarantool.org> <20190730224431.gwdxhbgrftrdmlgb@tkn_work_nb> <55cb38fd-df67-6858-5330-9c27a66adbd4@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55cb38fd-df67-6858-5330-9c27a66adbd4@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, Kirill Yukhin > >> diff --git a/test/swim/errinj.test.lua b/test/swim/errinj.test.lua > >> index cf0cb2dd4..6c73f9f3d 100644 > >> --- a/test/swim/errinj.test.lua > >> +++ b/test/swim/errinj.test.lua > >> @@ -26,6 +26,7 @@ s1:self():incarnation() > >> errinj.set("ERRINJ_SWIM_FD_ONLY", true) > >> s1:probe_member(s2:self():uri()) > >> errinj.set("ERRINJ_SWIM_FD_ONLY", false) > >> +while s1_view:incarnation().version ~= 2 do fiber.sleep(0.01) end > > > > Nit: Maybe it will be a bit better to stop after a certain time period > > if a condition is not meet after, say, a minute: this will allow > > test-run to continue with the test and possibly show more compact > > miscompare fail and also will allow continue with other tests that was > > already scheduled to the same worker. We use test_run:wait_cond() for > > this. Anyway, this is a thing of preference and I don't push anyone to > > one or another way: this message it just to let you know about both ways > > and the difference between them. (From the other hand explicit is better > > then implicit.) > > Such places are widespread in our tests. Perhaps it is worth introducing > a test-run helper for that. For example: > > test_run:wait(function() ... end, timeout) > > The function should return true, when the condition is met. This case > would look like this: > > test_run:wait(function() \ > return s1_view:incarnation().version == 2 \ > end, 60) I have mentioned it above: test_run:wait_cond(func, timeout, delay). https://github.com/tarantool/test-run/blob/947c65cda7f26ceb5f601bbf154e70f9c3f755e9/test_run.lua#L387