From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 995DB2121D for ; Tue, 30 Jul 2019 08:11:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AlYXtdJiCWDn for ; Tue, 30 Jul 2019 08:11:05 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 45ED020B25 for ; Tue, 30 Jul 2019 08:11:05 -0400 (EDT) Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1hsQy5-0007RE-K8 for tarantool-patches@freelists.org; Tue, 30 Jul 2019 15:11:02 +0300 Date: Tue, 30 Jul 2019 15:10:59 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 1/3] txn: move stmt list/savepoint manipulation out of txn_stmt_new Message-ID: <20190730121059.GD21469@atlas> References: <37bedba5d2f3670547633d0c70169e47d6f6476b.1564483378.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37bedba5d2f3670547633d0c70169e47d6f6476b.1564483378.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/07/30 15:04]: > txn_stmt_new is supposed to simply allocate an initialize a new txn_stmt > struct. Adding the new statement to the txn's statement list and setting > up a savepoint for rollback looks confusing. Move it to txn_begin_stmt. > --- lgtm -- Konstantin Osipov, Moscow, Russia