From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 29 Jul 2019 15:30:02 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH] txn: convert txn flags into bit mask Message-ID: <20190729123002.GE4659@esperanza> References: <7aafa5dcfee6521e4e73cc5f47640b7189b255e3.1564397497.git.vdavydov.dev@gmail.com> <20190729121410.GA16601@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190729121410.GA16601@atlas> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Mon, Jul 29, 2019 at 03:14:11PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [19/07/29 13:56]: > > --- > > https://github.com/tarantool/tarantool/commits/dv/txn-flags > > Curious, why not use bit fields? Personally I don't like bit fields, because AFAIK the way they are stored, accessed and updated depends on the compiler and, possibly, the underlying architercture. There might be some unexpected side effects, e.g. see https://lwn.net/Articles/478657/ If you prefer bit fields, no problem, I will change the patch as you like.