From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0AA92231F0
	for <tarantool-patches@freelists.org>; Mon, 29 Jul 2019 08:25:52 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Q53mC7ZLWNKh for <tarantool-patches@freelists.org>;
	Mon, 29 Jul 2019 08:25:51 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8C045231ED
	for <tarantool-patches@freelists.org>; Mon, 29 Jul 2019 08:25:51 -0400 (EDT)
Date: Mon, 29 Jul 2019 15:25:35 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] httpc: fix bug with segfault by
 wrong headers
Message-ID: <20190729122534.kml4nc6ripl7i4cj@tkn_work_nb>
References: <20190616152409.18534-1-roman.habibov@tarantool.org>
 <20190729105925.anvhupxae6zi2u2y@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190729105925.anvhupxae6zi2u2y@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@freelists.org, Roman Khabibov <roman.habibov@tarantool.org>

On Mon, Jul 29, 2019 at 01:59:25PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 16 Jun 18:24, Roman Khabibov wrote:
> > There wasn't lua_istable() checking for field 'headers'.
> > 
> > Closes #4281
> > ---
> > 
> > Branch: https://github.com/tarantool/tarantool/compare/romanhabibov/gh-4281-header
> > Issue: https://github.com/tarantool/tarantool/issues/4281
> 
> I've checked your patch into master.

https://github.com/tarantool/tarantool/issues/3679 was pushed to 2.1 and
1.10 too (85e1d78bc6605ab189b4253867a5f72ebf356f4a,
328ec3655021fb3eaf0441998f60d6c2630f1008).
https://github.com/tarantool/tarantool/issues/4281 is the bug according
to labels and we backport bugfixes backward as I understand our process.

I think this fix should be backported to 2.1 and 1.10.

BTW, the patch fixes a memleak: it is rare (only when arguments are
incorrect), but anyway.

WBR, Alexander Turenko.