From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Mon, 29 Jul 2019 11:45:04 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 2/4] txn: reverse commit trigger
 list only before running commit triggers
Message-ID: <20190729084504.GD4659@esperanza>
References: <cover.1563559254.git.vdavydov.dev@gmail.com>
 <833a22aef0330df6291250b3f9acb9461ff0cf55.1563559254.git.vdavydov.dev@gmail.com>
 <20190724224811.GA14292@atlas>
 <20190725092455.GH24631@esperanza>
 <20190725092948.GK15185@atlas>
 <20190725093528.GJ24631@esperanza>
 <20190725145642.GP24631@esperanza>
 <20190726192556.GB14622@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190726192556.GB14622@atlas>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Fri, Jul 26, 2019 at 10:25:56PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/25 17:57]:
> 
> LGTM
> > 
> > Commit triggers must be run in the same order they are added, see commit
> > 013432641283 ("txn: fix execution order of commit triggers"). To achieve
> > that we added a new trigger method, trigger_add_tail(), which adds new
> > triggers to the trigger list tail rather than to the head, and now we
> > use this new method for adding commit triggers.

Pushed to master along with the small library update.