From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 35AF620E2C
	for <tarantool-patches@freelists.org>; Sun, 28 Jul 2019 17:42:05 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id BtkolFnXGIGd for <tarantool-patches@freelists.org>;
	Sun, 28 Jul 2019 17:42:05 -0400 (EDT)
Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CB6F720E1B
	for <tarantool-patches@freelists.org>; Sun, 28 Jul 2019 17:42:04 -0400 (EDT)
Received: by mail-lj1-f195.google.com with SMTP id v18so56538987ljh.6
        for <tarantool-patches@freelists.org>; Sun, 28 Jul 2019 14:42:04 -0700 (PDT)
Date: Mon, 29 Jul 2019 00:42:01 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [tarantool-patches] Re: [PATCH 3/3] box/console: Test for nil value in args directly
Message-ID: <20190728214201.GC29098@uranus>
References: <20190726221712.11191-1-gorcunov@gmail.com>
 <20190726221712.11191-4-gorcunov@gmail.com>
 <20190728184702.GD13676@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190728184702.GD13676@atlas>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tml <tarantool-patches@freelists.org>, Alexander Turenko <alexander.turenko@tarantool.org>

On Sun, Jul 28, 2019 at 09:47:02PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [19/07/27 01:21]:
> > Instead of allocating a variable for optional args
> > testing we should use dot notation instead. Otherwise
> > it won't work for trivial test case as
> > 
> > ```
> > require('console').set_default_output('lua,block')
> > require('decimal').new('1234.5678')
> 
> Actually, could you add a test? then lgtm :)

Yes, tests are my first priority now. I've been reading test
engine code (the process is not that fast as I thought of)
and occasionally spotted the problem. Anyway I'll rework
the series and resend together with test. Thanks for review!