From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D31EF24779 for ; Sun, 28 Jul 2019 17:26:20 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2j6A5SyZj2Xg for ; Sun, 28 Jul 2019 17:26:20 -0400 (EDT) Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 16F4524480 for ; Sun, 28 Jul 2019 17:26:19 -0400 (EDT) Date: Mon, 29 Jul 2019 00:26:17 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/2] sql: extend struct Mem with field_type member Message-ID: <20190728212617.GC18418@atlas> References: <8be21965-b8ef-4f96-8ce3-99c2efcecfc0@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8be21965-b8ef-4f96-8ce3-99c2efcecfc0@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Nikita Pettik * Vladislav Shpilevoy [19/07/28 21:49]: > > const char *z = 0; > > UNUSED_PARAMETER(NotUsed); > > + enum field_type f_t = argv[0]->field_type; > > 1. Perhaps, field_type is not the best name, because Mem is not always > is a field. It can be just a value, not from a space. It is rather > just 'type'. > I think field_type is good because it's clear it's derived from enum field_type. Mem has more than one type now, so just "type" is ambiguous. My 0.02 -- Konstantin Osipov, Moscow, Russia