From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5CE9724622 for ; Sun, 28 Jul 2019 14:47:24 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Yvm5hJqTYTWs for ; Sun, 28 Jul 2019 14:47:24 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A410224615 for ; Sun, 28 Jul 2019 14:47:23 -0400 (EDT) Date: Sun, 28 Jul 2019 21:46:41 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 3/3] box/console: Test for nil value in args directly Message-ID: <20190728184641.GC13676@atlas> References: <20190726221712.11191-1-gorcunov@gmail.com> <20190726221712.11191-4-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190726221712.11191-4-gorcunov@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Cyrill Gorcunov Cc: tml , Alexander Turenko * Cyrill Gorcunov [19/07/27 01:21]: > Instead of allocating a variable for optional args > testing we should use dot notation instead. Otherwise > it won't work for trivial test case as Please remove extra "instead" > > ``` > require('console').set_default_output('lua,block') > require('decimal').new('1234.5678') > ``` > > | builtin/box/console.lua:47: expected decimal, number or string as 2 argument > > and program exits. > > Part-of #3834 > --- > src/box/lua/console.lua | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/box/lua/console.lua b/src/box/lua/console.lua > index 0c521b44a..64086cf5b 100644 > --- a/src/box/lua/console.lua > +++ b/src/box/lua/console.lua > @@ -41,10 +41,9 @@ output_handlers["yaml"] = function(status, opts, ...) > end > > output_handlers["lua"] = function(status, opts, ...) > - local data = ... > -- > -- Don't print nil if there is no data > - if data == nil then > + if not ... then > return "" > end > -- lgtm -- Konstantin Osipov, Moscow, Russia