From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AEE28255ED for ; Thu, 25 Jul 2019 05:29:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UH3nEU__ezZ6 for ; Thu, 25 Jul 2019 05:29:50 -0400 (EDT) Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6E1EB24B88 for ; Thu, 25 Jul 2019 05:29:50 -0400 (EDT) Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1hqa4K-0001EA-Ob for tarantool-patches@freelists.org; Thu, 25 Jul 2019 12:29:49 +0300 Date: Thu, 25 Jul 2019 12:29:48 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/4] txn: reverse commit trigger list only before running commit triggers Message-ID: <20190725092948.GK15185@atlas> References: <833a22aef0330df6291250b3f9acb9461ff0cf55.1563559254.git.vdavydov.dev@gmail.com> <20190724224811.GA14292@atlas> <20190725092455.GH24631@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725092455.GH24631@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/07/25 12:28]: > On Thu, Jul 25, 2019 at 01:48:11AM +0300, Konstantin Osipov wrote: > > * Vladimir Davydov [19/07/19 21:09]: > > > Commit triggers must be run in the same order they are added, see commit > > > 013432641283 ("txn: fix execution order of commit triggers"). To achieve > > > that we added a new trigger method, trigger_add_tail(), which adds new > > > triggers to the trigger list tail rather than to the head, and now we > > > use this new method for adding commit triggers. > > > > Commit triggers are a hot path. > > I wouldn't say they are - they are only used by DDL. commit path is always a hot path, and if the server itself invokes these triggers on DDL only, it doesn't mean users never invoke them on a hot path. But the server itself will use a lot of commit triggers when materialized views are implemented. -- Konstantin Osipov, Moscow, Russia