From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3C6C524ECE
	for <tarantool-patches@freelists.org>; Wed, 24 Jul 2019 18:48:14 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1f6jdMEHfxaK for <tarantool-patches@freelists.org>;
	Wed, 24 Jul 2019 18:48:14 -0400 (EDT)
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DBA3224EB7
	for <tarantool-patches@freelists.org>; Wed, 24 Jul 2019 18:48:13 -0400 (EDT)
Received: by smtp34.i.mail.ru with esmtpa (envelope-from <kostja@tarantool.org>)
	id 1hqQ3P-0005Ch-VH
	for tarantool-patches@freelists.org; Thu, 25 Jul 2019 01:48:12 +0300
Date: Thu, 25 Jul 2019 01:48:11 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/4] txn: reverse commit trigger list
 only before running commit triggers
Message-ID: <20190724224811.GA14292@atlas>
References: <cover.1563559254.git.vdavydov.dev@gmail.com>
 <833a22aef0330df6291250b3f9acb9461ff0cf55.1563559254.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <833a22aef0330df6291250b3f9acb9461ff0cf55.1563559254.git.vdavydov.dev@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/07/19 21:09]:
> Commit triggers must be run in the same order they are added, see commit
> 013432641283 ("txn: fix execution order of commit triggers"). To achieve
> that we added a new trigger method, trigger_add_tail(), which adds new
> triggers to the trigger list tail rather than to the head, and now we
> use this new method for adding commit triggers.

Commit triggers are a hot path.

Since this is a *double linked list* you don't need to reverse it
to *iterate over it in reverse order*.

Thanks :(

-- 
Konstantin Osipov, Moscow, Russia